thswlsqls commented on PR #39364: URL: https://github.com/apache/shardingsphere/pull/39364#issuecomment-5340427512
@terrymanu Thanks for the review and for the pointer to #39389 — closing makes sense, the two changes are equivalent. One thing carried over: the `to-y=0` public-path gap you flagged here still applies on master, where both algorithm tests use `from-x=0, to-y=2`, so reverting `createToY` to `checkPositiveInteger` would stay green. Happy to send a small follow-up adding the `to-y=0` cases and the release note if that's useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
