joelle-a-dev opened a new pull request, #39519:
URL: https://github.com/apache/shardingsphere/pull/39519

   ## Summary
   
   Adds Doris SQL parser support for the items tracked in #31506:
   
   - `BITOR(a, b)`: new bitwise function, following the existing `BITXOR` 
pattern.
   - `ARRAY_LAST(lambda, array)`: new lambda expression grammar (`x -> expr`) 
and function rule, since Doris had no prior support for lambda-style array 
functions.
   - `MAX([DISTINCT | ALL]) ... OVER (...)`: added the missing `ALL` qualifier 
alternative to aggregation functions.
   - `HEX()`, `LOCATE()`, `bitmap_to_string()`: already parsed correctly via 
the generic function-call grammar, just added/extended test coverage for Doris.
   - `INSTALL PLUGIN FROM`: already fully implemented, no changes needed.
   
   While adding `OVER`-clause test coverage for `MAX`, found that Doris's 
visitor never attached window-clause info to aggregation projections at all, so 
any `MAX`/`SUM`/`COUNT`/etc. `... OVER (...)` silently lost its window segment. 
Added the missing `visitOverClause` and wired `setWindow(...)` into both 
aggregation projection branches, matching the existing MySQL visitor behavior. 
This also fixes two pre-existing Doris test cases that had been passing only 
because they never asserted the (missing) window item.
   
   ## Test plan
   
   - [x] `InternalDorisParserIT` passes: 1292/1292, including all new and 
previously-affected cases
   - [x] `checkstyle:check` passes on touched modules
   - [x] `spotless:apply` applied, no outstanding formatting diffs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to