menghaoranss commented on PR #39515: URL: https://github.com/apache/shardingsphere/pull/39515#issuecomment-5351030875
```markdown ### Result **Review Result: Mergeable** The change consistently uses the database metadata owner’s resolved default schema for insert metadata lookup and generated-key algorithm context. ### Evidence - [`appendMissingShardingConditions`](https://github.com/apache/shardingsphere/blob/20136ead763bda769be603950b3f3684c2a28562/features/sharding/core/src/main/java/org/apache/shardingsphere/sharding/route/engine/condition/engine/InsertClauseShardingConditionEngine.java#L94-L107) resolves unqualified inserts through `database.findDefaultSchema()` and reports a missing schema explicitly. - [`appendGeneratedKeyConditions`](https://github.com/apache/shardingsphere/blob/20136ead763bda769be603950b3f3684c2a28562/features/sharding/core/src/main/java/org/apache/shardingsphere/sharding/route/engine/condition/engine/InsertClauseShardingConditionEngine.java#L173-L183) passes `database.getDefaultSchemaName()` to `AlgorithmSQLContext` when SQL does not specify a schema. - [Focused regression coverage](https://github.com/apache/shardingsphere/blob/20136ead763bda769be603950b3f3684c2a28562/features/sharding/core/src/test/java/org/apache/shardingsphere/sharding/route/engine/condition/engine/InsertClauseShardingConditionEngineTest.java#L164-L193) verifies missing-default-schema handling and the generated-key schema context. - Focused verification passed: `InsertClauseShardingConditionEngineTest` — 12 tests, 0 failures, 0 errors, exit code 0. ### Coverage - Reviewed head: `20136ead763bda769be603950b3f3684c2a28562`. - Merge base: `9fdc12bd541c4d23210a7bbba82ed92c8537faf3`. - The authoritative GitHub scope and local triple-dot scope matched: 2 files reviewed. - Reviewed the default-schema-aware insert-condition cluster across omitted-column metadata lookup, explicit-schema preservation, generated-key context, exceptions, and existing insert paths. - Completed root-cause/behavior, blast-radius/contracts, tests/runtime/operations, and final convergence passes. - No unresolved correctness gaps or blocking issues. - Code-correctness result only; CI was not reviewed. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
