terrymanu commented on PR #39590: URL: https://github.com/apache/shardingsphere/pull/39590#issuecomment-5390504909
Thank you for the contribution. **Current status: Retained — this PR has been superseded and can be closed.** [PR #39586](https://github.com/apache/shardingsphere/pull/39586) was merged as commit [`701077d6`](https://github.com/apache/shardingsphere/commit/701077d6c96bc2c262a73b85c3e0d58733435f5a). It added Doris `BITOR` grammar support and parser assertions, and closed [#31509](https://github.com/apache/shardingsphere/issues/31509). The `BITOR` changes in this PR are therefore duplicates of code already on `master`. The remaining changes do not require keeping this PR open: - `BITAND` already parses through the generic function path; this was also [verified by a maintainer](https://github.com/apache/shardingsphere/issues/31473#issuecomment-5385979524). The proposed dedicated rule would regress non-literal arguments such as `BITAND(col_a, col_b)` by representing the columns as literal expressions. - The comma form of `SUBSTR` has already been supported since [#31257](https://github.com/apache/shardingsphere/pull/31257). - The additional `ADMIN COPY TABLET` grammar changes are unrelated and do not match the documented executable syntax. - The five root-level Python files are temporary patch or rollback scripts and are not part of the required implementation. Closing this PR as superseded is the appropriate next step. If a separate reproducible `BITOR` or `BITAND` AST issue remains, please open a focused issue and PR for that behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
