terrymanu commented on issue #18860: URL: https://github.com/apache/shardingsphere/issues/18860#issuecomment-5391030070
Hi @JiekerTime, thanks for reporting this. The core bug has been fixed on the current master, so this issue can be closed as completed. PR #38186 maps `SET NAMES` to `character_set_client`, `character_set_results`, and `character_set_connection`. PR #39383 further tracks these values independently in the Proxy session and applies them to request decoding, response encoding, and backend connection collation. `SHOW VARIABLES` may still display values from the selected backend connection because that statement is executed on the database. This is a separate observability and compatibility concern tracked by #23006; it does not mean that `SET NAMES` is ineffective in the Proxy data path. We will close this issue as completed. Please reopen it if the current master still produces an actual request or response encoding error rather than only a different `SHOW VARIABLES` result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
