sandynz commented on PR #39606:
URL: https://github.com/apache/shardingsphere/pull/39606#issuecomment-5423361760
### Result
**Review Result: Mergeable**
The latest commit replaces the internal insert-value-context list with a
pre-sized `ArrayList`. It preserves existing `List` behavior while improving
indexed-access performance. The
regression test uses two actual VALUES groups to verify the `RandomAccess`
contract.
### Evidence
- Element ordering, duplicate handling, and parameter-offset logic remain
unchanged.
- Encrypt and generated-key parameter rewriters perform indexed access.
- No production consumer depends on the concrete `LinkedList` type.
- `InsertStatementContextTest`: exit 0.
- Spotless check: exit 0.
- Checkstyle: exit 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
