The GitHub Actions job "E2E - SQL" on 
shardingsphere.git/fix-timestamp-truncation-negative has succeeded.
Run started by GitHub user PDGGK (triggered by PDGGK).

Head commit for run:
8af2416eabf1d198340ad537cca601e2ffc9870e / Zihan Dai <[email protected]>
Truncate timestamps towards the past when comparing them for consistency

isMatched drops sub-second precision with getTime() / 1000 * 1000. Integer
division truncates towards zero, so a pre-epoch value is rounded up into the
second above the one it belongs to.

The comparison then goes wrong both ways: -1500 and -1000 are half a second
apart in different seconds and are reported as matching, while -1000 and -999
are a millisecond apart in the same second and are reported as different.

Use Math.floorDiv, which is unchanged above the epoch.

Report URL: https://github.com/apache/shardingsphere/actions/runs/32979506973

With regards,
GitHub Actions via GitBox

Reply via email to