strongduanmu commented on PR #39607:
URL: https://github.com/apache/shardingsphere/pull/39607#issuecomment-5433638309
• ### Correction
Previous Finding:
The `parsing and binding` wording in `RELEASE-NOTES.md` exceeds the scope
of the current implementation.
Current Status: Withdrawn
Reason:
Per the review scope for this round, the release note wording issue is
ignored and is not treated as a merge blocker.
### Result
**Review Result: Mergeable**
No code correctness issues requiring merge blockage were found in the
current head.
### Evidence
- `OracleDDLStatementVisitor.java` collects function/procedure routine
names from Oracle package specifications and package bodies.
- `CreatePackageStatement.java` exposes the `getPackageRoutineNames()`
contract, and `OracleCreatePackageStatement.java` stores the corresponding
result.
- `OracleCreatePackageStatementAssert.java` and `create-package.xml` add
assertions for routine name count, order, name, and position.
- Oracle parser IT, Spotless, and Checkstyle have passed.
### Coverage
- Reviewed PR: `apache/shardingsphere#39607`
- Reviewed head: `e62d5cb658b198b0c9e2398a8d0e5463a68fb904`
- Reviewed files: all 8 GitHub changed files were covered.
- Focus: Code Correctness Review.
- CI/E2E: Reported as passed by the user; Actions were not queried in this
review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
