terrymanu commented on PR #39612: URL: https://github.com/apache/shardingsphere/pull/39612#issuecomment-5433892534
### Result **Review Result: Mergeable** No code-correctness blockers were found in the latest commit, `8f79c260`. This conclusion applies only to the latest commit and does not cover all 27 files in the PR. ### Evidence - Scope: [8f79c260](https://github.com/apache/shardingsphere/commit/8f79c2605eeb729410710c1fd1312d54930ae50f), with parent `5f62235e`. GitHub and local `parent..head` lists match exactly: 8 files. - CDC selector parsing now merges multiple schema-wildcard results and reports missing schemas with explicit SQL exceptions. - Persisted CDC configurations are revalidated before startup. Validation failure stops the previous instance, disables the configuration, and preserves cleanup failures as suppressed exceptions. - The Netty handler retains request IDs and returns the appropriate metadata or invalid-parameter SQLState. - Complete module tests passed: 125 tests in CDC core and 85 tests in Proxy frontend core, with no failures or errors. - Spotless and Checkstyle passed. The initial test failure was confirmed to be caused by sandbox restrictions on Byte Buddy JVM attachment; the identical command passed outside the sandbox. ### Coverage - Files: all 4 changed production files and their 4 corresponding test files. - Behavior clusters: selector resolution, job startup validation and lifecycle, and protocol error propagation. - Review lenses completed: root cause and behavior, blast radius and contracts, tests/runtime/operations, failure and concurrency boundaries, and final full-scope convergence. - Unresolved evidence gaps: none. - Focus: Code Correctness Review. This is a code-scope result only; CI was not queried or reviewed. - External or cross-model review was not performed because repository policy prohibits additional Codex tasks and external review services. A bounded adversarial self-review was completed within the current task. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
