PDGGK commented on PR #39603: URL: https://github.com/apache/shardingsphere/pull/39603#issuecomment-5460426301
You're right, and it's worse than the original problem: the self-suppression aborts the very loop this change added, so later statements stay open and the caller gets IllegalArgumentException instead of SQLWrapperException. Fixed in 5c61e414 with a same-instance guard in appendFailure, plus a regression test where two statements throw one shared SQLException and a third is still closed. Reverting the guard fails that test with "Self-suppression not permitted" replacing SQLWrapperException, which is exactly the path you described. mvn test -pl kernel/sql-federation/executor - 24 tests, all passing. Checkstyle clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
