PDGGK commented on PR #39611:
URL: https://github.com/apache/shardingsphere/pull/39611#issuecomment-5460427409
Both fixed in 990bccb3.
The twelve invocations are now two parameterized tests with name = "{0}",
one per input type, each converting once:
assertConvertPreEpochSqlTimestampToTimestampMessage and
assertConvertPreEpochUtilDateToTimestampMessage, over six named cases. The
nanos-range and round-trip assertions are kept.
The line comments in both files are removed, per CODE_OF_CONDUCT.md.
mvn test -pl kernel/data-pipeline/scenario/cdc/core - 132 tests, all
passing. Checkstyle clean. Reverting the fix fails four of the parameterized
cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
