PDGGK commented on PR #39610:
URL: https://github.com/apache/shardingsphere/pull/39610#issuecomment-5460427317
Both fixed in 8593b85d.
On the comments: CODE_OF_CONDUCT.md permits only Javadoc, TODO and FIXME,
and you are right that Spotless passing says nothing about that rule. The two
line comments are gone; the helper carries the intent in its name instead -
toSeconds is now toFlooredSeconds.
On the test: it is now a @ParameterizedTest(name = "{0}") with four cases,
each naming its scenario and calling isMatched once - different seconds before
epoch, different seconds across epoch, same second before epoch, sub second
tolerance before epoch. Reverting the fix now fails three of them by name
rather than pointing at one line.
mvn test -pl kernel/data-pipeline/core - 325 tests, all passing. Checkstyle
clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
