terrymanu commented on PR #39655: URL: https://github.com/apache/shardingsphere/pull/39655#issuecomment-5469100046
### Result **Review Result: Mergeable** The implementation correctly prohibits imports from `.shaded.` package segments while preserving the existing `sun.*` restriction. No code-correctness blockers were found. ### Evidence - [`src/resources/checkstyle.xml:168`](https://github.com/apache/shardingsphere/blob/5d26988b727a28b31ff4980d8439eb4df79c9b35/src/resources/checkstyle.xml#L168-L171) is consistent with Checkstyle 14.0.0 `IllegalImport` regular-expression semantics. - Pinned-version behavior verification confirmed that `sun.misc.Unsafe`, `com.foo.shaded.Bar`, and shaded static imports are rejected, while `com.foo.shadedness.Bar` and `com.foo.unshaded.Bar` are not falsely rejected. - Maven configuration validation succeeded: `checkstyle:check` exited with code 0 and reported zero violations. - The local triple-dot file list matches GitHub’s authoritative changed-file list. ### Coverage - Candidate type: Public PR. - Reviewed head: `5d26988b727a28b31ff4980d8439eb4df79c9b35`. - Merge base: `44e5d3c29c981e42f4f3f86c2242f67404beee99`. - All changed files reviewed: `src/resources/checkstyle.xml` (1 of 1). - Behavior cluster: Global Checkstyle enforcement against shaded imports. - Completed review lenses: root cause and behavior, blast radius and contracts, tests and runtime, and full-scope convergence. - Unresolved evidence gaps: None. - This is a code-scope correctness result; CI was not reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
