rishi-rana opened a new pull request, #39660:
URL: https://github.com/apache/shardingsphere/pull/39660
Fixes #39359.
Changes proposed in this pull request:
- `CreateMaskRuleExecutor.checkDuplicatedRuleNames()`: copy current table
names into a `CaseInsensitiveSet` instead of `Collectors.toList()`, so `CREATE
MASK RULE T_ORDER` over an existing `t_order` now raises
`DuplicateRuleException` instead of storing a duplicate.
- `AlterMaskRuleExecutor.checkToBeAlteredRules()`: same fix, so `ALTER MASK
RULE T_ORDER` no longer fails with `MissingRequiredRuleException` when only
`t_order` exists.
- `AlterMaskRuleExecutor.buildToBeDroppedRuleConfiguration()`: same fix for
the `toBeAlteredTableNames` comparison, so a case-differing ALTER no longer
leaves the old table's algorithm incorrectly counted as still in use.
- Matches the existing `CaseInsensitiveSet` pattern already used in
`DropMaskRuleExecutor` and applied to the sibling broadcast rule type in #39200.
- Added case-insensitive unit test coverage to both executor test classes.
This pull request was drafted with assistance from Claude Code (Anthropic).
Affected scope: the three executor methods above and their corresponding unit
tests in `CreateMaskRuleExecutorTest`/`AlterMaskRuleExecutorTest`. I reviewed
and verified all changes myself.
---
Before committing this PR, I'm sure that I have checked the following
options:
- [x] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the
pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
- [x] I have updated the Release Notes of the current development version.
For more details, see [Update Release
Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
