terrymanu commented on PR #39661: URL: https://github.com/apache/shardingsphere/pull/39661#issuecomment-5473198987
### Result **Review Result: Mergeable** The Spotless upgrade preserves the existing Eclipse formatter behavior and runs the required check on a compatible JDK. ### Evidence - [`pom.xml:183`](https://github.com/apache/shardingsphere/blob/3e93491510a2e652e5218fac1b429c8999bbafea/pom.xml#L183) upgrades Spotless to 3.10.1; [`pom.xml:1325-1328`](https://github.com/apache/shardingsphere/blob/3e93491510a2e652e5218fac1b429c8999bbafea/pom.xml#L1325) pins Eclipse 4.35, avoiding the newer default formatter output. - [Spotless 3.0.0](https://github.com/diffplug/spotless/releases/tag/maven/3.0.0) requires Java 17 or later. [`.github/workflows/required-check.yml:52-65`](https://github.com/apache/shardingsphere/blob/3e93491510a2e652e5218fac1b429c8999bbafea/.github/workflows/required-check.yml#L52) configures Temurin 21 before invoking Spotless. - [Spotless 3.10.0](https://github.com/diffplug/spotless/releases/tag/maven/3.10.0) documents embedded Eclipse JDT lockfiles covering version 4.35. - `./mvnw spotless:check -Pcheck -T1C` completed with exit code 0 and `BUILD SUCCESS` on Temurin 21 / Maven 3.9.14. - `git diff --check` completed with exit code 0. ### Coverage - Candidate: public PR #39661 at head `3e93491510a2e652e5218fac1b429c8999bbafea`. - Base and merge-base: `f8cf088c84e5fd5942f2287be58c4855e8ec4704`. - GitHub and local triple-dot scope matched: `.github/workflows/required-check.yml` and `pom.xml`. - Reviewed clusters: Spotless/JDT versioning and required-check JDK selection. - Completed root-cause, blast-radius/contracts, tests/runtime/operations, dependency/distribution, and final convergence review. - No unresolved evidence gaps or blocking findings. - Code-correctness result only; CI status and Actions runs were not reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
