menghaoranss commented on PR #39691: URL: https://github.com/apache/shardingsphere/pull/39691#issuecomment-5506167068
```markdown ### Result **Review Result: Mergeable** The factory consistently delegates protocol default-schema normalization to the established resolver, and no code-correctness blocker was found. ### Evidence - [`ShardingSphereDatabaseFactory.java:66`](https://github.com/apache/shardingsphere/blob/507f9cac9d2a6274c4d388a2884555b5cd1b8f4f/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/ShardingSphereDatabaseFactory.java#L66) and [`:141`](https://github.com/apache/shardingsphere/blob/507f9cac9d2a6274c4d388a2884555b5cd1b8f4f/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/ShardingSphereDatabaseFactory.java#L141) now use `DefaultSchemaNameResolver.resolveProtocol` for both system-database creation and metadata rebuilding. - The resolver preserves fixed dialect schemas and applies the protocol identifier policy when the database name supplies the schema. - [`ShardingSphereDatabaseFactoryTest.java:85-128`](https://github.com/apache/shardingsphere/blob/507f9cac9d2a6274c4d388a2884555b5cd1b8f4f/infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/database/ShardingSphereDatabaseFactoryTest.java#L85-L128) verifies delegation and resulting schema composition. - Focused Maven test: 8 tests passed, 0 failures or errors; exit code 0. - Scoped Spotless and Checkstyle checks passed with no violations; exit code 0. ### Coverage - Candidate: public PR #39691 at head `507f9cac9d2a6274c4d388a2884555b5cd1b8f4f`. - All two authoritative changed files were reviewed: one production file and one test file. - Reviewed behavior clusters: protocol default-schema resolution, system-schema insertion, generic schema-builder material construction, identifier normalization, null/fixed-schema behavior, and test validity. - Completed root-cause, blast-radius/contracts, tests/runtime, and final convergence passes with no unresolved findings. - The unchanged translating-logic migration was excluded as requested; its interaction with the new resolver input was checked. - Unrelated local untracked files were excluded from the candidate. - This is a code-correctness result only; CI status was not reviewed. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
