menghaoranss commented on PR #39700: URL: https://github.com/apache/shardingsphere/pull/39700#issuecomment-5520424429
```markdown ### Result **Review Result: Mergeable** The latest commit adds a regression test that distinguishes the new implementation from the previous behavior. No additional code-correctness issues were found. ### Evidence - The [`DataNode` compatibility constructor](https://github.com/apache/shardingsphere/blob/6af60b0ae4cdd6e7b0514f1720fb03942ceda84a/infra/common/src/main/java/org/apache/shardingsphere/infra/datanode/DataNode.java#L72-L74) correctly delegates to `DefaultSchemaNameResolver.resolveProtocol`. - [`mysql_normalizes_mixed_case_database_schema`](https://github.com/apache/shardingsphere/blob/6af60b0ae4cdd6e7b0514f1720fb03942ceda84a/infra/common/src/test/java/org/apache/shardingsphere/infra/datanode/DataNodeTest.java#L168-L170) verifies the public constructor’s protocol normalization using `Foo_DB` → `foo_db`. Reverting to the previous implementation would fail this test. - `DataNodeTest`: all 49 tests passed. - `git diff --check`: passed. - Both production call paths were reviewed: `SingleTableLoadUtils.convertToDataNodes` and the compatibility fallback in `SingleTableDataNodeLoader`. ### Coverage - Candidate: public PR #39701 at head `6af60b0ae4cdd6e7b0514f1720fb03942ceda84a`. - Base and merge-base: `6da1738092a15a29e516e0b99ace340b1ce64697`. - All 2 authoritative GitHub-listed files were reviewed; the GitHub file list matches the local triple-dot diff. - Root cause and behavior, blast radius and contracts, tests and runtime, and final convergence reviews were completed. - No unresolved evidence gaps or local-only candidate changes. - This is a code-correctness result; CI was not reviewed. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
