terrymanu commented on PR #39706:
URL: https://github.com/apache/shardingsphere/pull/39706#issuecomment-5521292196
### Result
**Review Result: Mergeable**
The root POM exclusion correctly removes ZooKeeper’s transitive tcnative
dependencies while preserving Proxy’s direct tcnative/OpenSSL dependency chain.
### Evidence
- Changed only `pom.xml`: added an exclusion for
`io.netty:netty-tcnative-boringssl-static` under the managed ZooKeeper
dependency.
- ZooKeeper provider: retains `org.apache.zookeeper:zookeeper:3.9.5`; no
tcnative artifacts are resolved. `netty-handler` and the Netty components
required for JDK SSL remain.
- JDBC distribution with `mode-repo-zookeeper`: retains ZooKeeper and
resolves no tcnative artifacts.
- Proxy frontend core still directly resolves:
- `netty-tcnative-boringssl-static:2.0.74.Final`
- `netty-tcnative-classes`
- Linux x86_64/aarch64
- macOS x86_64/aarch64
- Windows x86_64 native packages
- The Proxy POM, `ProxySSLContext`, related tests, and Proxy LICENSE have no
task changes. Existing OpenSSL support remains intact.
- Spotless: exit code 0; no additional formatting changes.
- Root effective POM: exit code 0; the ZooKeeper exclusion is present.
- Related module package build: exit code 0.
- `git diff --check -- pom.xml`: exit code 0.
- Final task diff: only `pom.xml`, with 4 additions and no deletions.
Not run: the full repository `clean install -Pcheck`, unit tests,
release-profile archive assembly, and a live Proxy SSL handshake test. The
requested dependency trees, effective POM check, and scoped module build
directly cover this dependency-management-only change.
### Coverage
- Candidate type: standalone local candidate.
- Baseline: `1227726d1d2435318c0fc9ffe2dfe66ecd5bff44`.
- Task delta: `pom.xml -> exclude ZooKeeper-transitive tcnative -> prevent
JDBC/ZooKeeper packaging of native SSL artifacts`.
- No blocking findings or unresolved evidence gaps.
- CI was not reviewed; this is a local code-scope result.
- Preserved unrelated untracked directories:
- `.codex/harness/agents/__pycache__/`
- `.codex/skills/review-pr/scripts/__pycache__/`
- No Git add, commit, push, or other Git write operation was executed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
