menghaoranss commented on PR #39707: URL: https://github.com/apache/shardingsphere/pull/39707#issuecomment-5521521832
```markdown ### Result **Review Result: Mergeable** The no-data-source path now uses `DefaultSchemaNameResolver.resolveProtocol` while preserving the existing database-type selection, schema-availability handling, data-source-aware path, and table-matching behavior. ### Evidence - The production change is limited to replacing the deprecated default-schema lookup in the no-data-source branch. - The updated test provides a distinct protocol-resolved schema name and verifies that it reaches the DataNode conversion path. - Reverting to the previous registry lookup would cause the regression test to fail. - All 16 focused tests passed. - Spotless, Checkstyle, and `git diff --check` passed. ### Coverage - Reviewed head: `0b1ce15cea5fa1ec5479b979f46203f67d864096`. - Merge base: `d8df72805f61bfa266297c3b10f92c420fd1d7f2`. - All two changed files were reviewed. - The GitHub and local triple-dot file inventories matched. - No unresolved code-correctness issues or evidence gaps remain. - This is a code-scope result only; CI was not reviewed. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
