FlyingZC commented on PR #39709:
URL: https://github.com/apache/shardingsphere/pull/39709#issuecomment-5522341970
### Result
**Review Result: Mergeable**
The effective candidate—PR #39709 plus the local fix—preserves
parameter-marker aliases and available bound metadata without losing the
`ColumnSegment`
constructor’s default metadata.
### Evidence
- `ColumnSegmentBinder.java:318` retains the constructor-provided metadata
when the parameter marker has no bound information.
- The existing test verifies that non-null bound information is copied
completely.
- `ColumnSegmentBinderTest.java:131` exercises an aliased external-table
parameter-marker projection without calling `setBoundInfo`, verifying non-null
metadata
and preservation of the original column alias.
- Outer-table and external-table resolution share the same
`createColumnSegment` conversion, so a duplicate outer-table test is
unnecessary.
- Spotless passed.
- Checkstyle passed with zero violations.
- `ColumnSegmentBinderTest` passed: 16 tests, 0 failures, 0 errors, 0
skipped.
### Coverage
- Candidate type: PR-backed local candidate.
- Public PR head: `02d607b9d8d149fa838b599580dba90c35e93cec`.
- Local uncommitted delta: two existing PR files, 17 additions and 1
deletion.
- Root-cause, blast-radius, tests/runtime, and convergence passes are
complete.
- No MERGE, parser, or encrypt files were changed.
- The public PR does not yet contain this local fix and remains blocked
until the fix is committed and pushed.
- This is a code-correctness review; CI was not reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
