FlyingZC commented on PR #39710:
URL: https://github.com/apache/shardingsphere/pull/39710#issuecomment-5522232189
### Result
**Review Result: Mergeable**
The patch addresses all three Oracle DML parser issues with a focused
implementation. No blocking correctness, compatibility, or performance issues
were found.
### Evidence
- MERGE UPDATE and INSERT values now support scalar subqueries and produce
the expected subquery expression segments.
- UPDATE assignments no longer append the same column twice after
constructing `ColumnAssignmentSegment`.
- Unqualified `SYSDATE` and `SYSTIMESTAMP` expressions are represented as
`FunctionSegment`; qualified, nested, and quoted identifiers retain column
semantics.
- Oracle’s official MERGE and system datetime function syntax supports the
implemented behavior.
- `OracleDMLStatementVisitorTest`: 6 tests passed.
- `InternalOracleParserIT`: 1,947 tests passed.
- The file-scoped Spotless check passed.
- Checkstyle passed with zero violations.
### Coverage
- Pull request: https://github.com/apache/shardingsphere/pull/39710
- Reviewed head: `7f00db1e51f19e79cf21df4027c61e5d34f46e11`
- Reviewed all seven changed files.
- Covered behavior clusters:
- MERGE scalar subqueries
- Oracle system datetime functions
- UPDATE assignment column cardinality
- Completed root-cause, blast-radius, tests/runtime, and convergence
reviews.
- Oracle is an independent trunk dialect, so no branch dialect
synchronization is required.
- No unresolved code-scope evidence gaps remain.
- GitHub CI was still pending and was not included in this
code-correctness verdict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
