menghaoranss commented on PR #39712: URL: https://github.com/apache/shardingsphere/pull/39712#issuecomment-5524406782
```markdown ### Result **Review Result: Mergeable** The change consistently uses protocol-aware default-schema resolution in SQL integration-test fixtures, with no correctness, compatibility, or style issues found. ### Evidence - [`HavingCorrelatedSubqueryBinderIT`](https://github.com/apache/shardingsphere/blob/a3167aa5f3edc70d8146409c9c81e9c093d633ca/test/it/binder/src/test/java/org/apache/shardingsphere/test/it/sql/binder/HavingCorrelatedSubqueryBinderIT.java#L96-L100), [`SQLBinderIT`](https://github.com/apache/shardingsphere/blob/a3167aa5f3edc70d8146409c9c81e9c093d633ca/test/it/binder/src/test/java/org/apache/shardingsphere/test/it/sql/binder/SQLBinderIT.java#L103-L108), and [`SQLRewriterIT`](https://github.com/apache/shardingsphere/blob/a3167aa5f3edc70d8146409c9c81e9c093d633ca/test/it/rewriter/src/test/java/org/apache/shardingsphere/test/it/rewriter/engine/SQLRewriterIT.java#L182-L192) correctly pass the protocol database type to `DefaultSchemaNameResolver.resolveProtocol`. - The replacement preserves dialect-specific default-schema behavior while removing direct use of the deprecated registry API. - Focused verification passed: - `HavingCorrelatedSubqueryBinderIT`: 4 tests. - `MySQLBinderIT`: 57 tests. - `MixSQLRewriterIT`: 58 tests. - All 119 executed tests passed with no failures or errors. - `git diff --check` passed. ### Coverage Reviewed the latest public head `a3167aa5f3edc70d8146409c9c81e9c093d633ca` against base `63a188eacaac9a5779b9ddda4e6f8af56e62546d`. GitHub and local triple-dot inventories matched at 3/3 files. All behavior clusters and regression lenses were covered; no local-only candidate changes were included. CI status was outside this code-correctness review. Applied the repository’s `$review-pr` formal-review workflow and coding-standard checks. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
