terrymanu commented on PR #39718:
URL: https://github.com/apache/shardingsphere/pull/39718#issuecomment-5526703059
### Result
**Review Result: Mergeable**
Clarified eight coding-standard areas across the canonical document and both
documentation translations. The rules now define explicit conditions instead of
vague preferences or contradictory exceptions.
### Evidence
- Updated readability and moved self-explanatory naming into the development
philosophy.
- Removed the unsupported Checkstyle exception for local-variable `final`.
- Reconciled the nullability and `Optional` parameter rules.
- Defined when Lombok, collection capacity, ternary expressions, guard
clauses, and `@HighFrequencyInvocation` apply.
- Preserved the three existing prohibitions for high-frequency code.
- `git diff --check` passed.
- Superseded wording is absent from all three files.
- Policy validation and all 8 source-read traces passed.
- Full policy evaluation improved from the 109/110 baseline to 110/110, with
no critical regressions.
- Checkstyle and Spotless are not applicable to these Markdown files.
### Coverage
- Candidate type: standalone local documentation candidate.
- Baseline: `d585b73a2993612568711940e2217625b5c45f06`.
- Reviewed files:
- `CODE_OF_CONDUCT.md`
- `docs/community/content/involved/conduct/code.en.md`
- `docs/community/content/involved/conduct/code.cn.md`
- Each file contains only the synchronized rule clarifications required by
the task.
- No production code, tests, runtime behavior, architecture, or dependencies
changed.
- Existing untracked `__pycache__` directories were excluded and left
untouched.
- No unresolved findings or evidence gaps.
- This is a code-scope review; CI was not reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
