This is an automated email from the ASF dual-hosted git repository.
menghaoranss pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 97bdb8a1193 Remove the deprecated method tests (#39719)
97bdb8a1193 is described below
commit 97bdb8a11930f255904d2908a0def5cc53439046
Author: Haoran Meng <[email protected]>
AuthorDate: Thu Sep 3 21:58:24 2026 +0800
Remove the deprecated method tests (#39719)
---
.../core/type/DatabaseTypeRegistryTest.java | 30 ----------------------
1 file changed, 30 deletions(-)
diff --git
a/database/connector/core/src/test/java/org/apache/shardingsphere/database/connector/core/type/DatabaseTypeRegistryTest.java
b/database/connector/core/src/test/java/org/apache/shardingsphere/database/connector/core/type/DatabaseTypeRegistryTest.java
index 24f25025faa..fa3754c9045 100644
---
a/database/connector/core/src/test/java/org/apache/shardingsphere/database/connector/core/type/DatabaseTypeRegistryTest.java
+++
b/database/connector/core/src/test/java/org/apache/shardingsphere/database/connector/core/type/DatabaseTypeRegistryTest.java
@@ -53,20 +53,6 @@ class DatabaseTypeRegistryTest {
assertTrue(new
DatabaseTypeRegistry(branchDatabaseType).getAllBranchDatabaseTypes().isEmpty());
}
- @ParameterizedTest(name = "{0}")
- @MethodSource("getDefaultSchemaNameArguments")
- void assertGetDefaultSchemaName(final String name, final String
databaseType, final String databaseName, final String expectedSchemaName) {
- assertThat(new
DatabaseTypeRegistry(TypedSPILoader.getService(DatabaseType.class,
databaseType)).getDefaultSchemaName(databaseName), is(expectedSchemaName));
- }
-
- @ParameterizedTest(name = "{0}")
- @MethodSource("getDefaultSchemaNameWithIdentifierPatternArguments")
- void assertGetDefaultSchemaNameWithIdentifierPattern(final String name,
final IdentifierPatternType identifierPatternType,
- final String
defaultSchema, final String databaseName, final String expectedSchemaName)
throws ReflectiveOperationException {
- DatabaseTypeRegistry databaseTypeRegistry =
createDatabaseTypeRegistry(identifierPatternType, defaultSchema);
- assertThat(databaseTypeRegistry.getDefaultSchemaName(databaseName),
is(expectedSchemaName));
- }
-
@ParameterizedTest(name = "{0}")
@MethodSource("formatIdentifierPatternArguments")
void assertFormatIdentifierPattern(final String name, final
IdentifierPatternType identifierPatternType, final String
expectedIdentifierPattern) throws ReflectiveOperationException {
@@ -74,22 +60,6 @@ class DatabaseTypeRegistryTest {
assertThat(databaseTypeRegistry.formatIdentifierPattern("Foo"),
is(expectedIdentifierPattern));
}
- private static Stream<Arguments> getDefaultSchemaNameArguments() {
- return Stream.of(
- Arguments.of("database type contains default schema", "TRUNK",
"FOO", "test"),
- Arguments.of("database type does not contain default schema",
"BRANCH", "FOO", "FOO"),
- Arguments.of("database name is null", "BRANCH", null, null));
- }
-
- private static Stream<Arguments>
getDefaultSchemaNameWithIdentifierPatternArguments() {
- return Stream.of(
- Arguments.of("fixed default schema remains unchanged",
IdentifierPatternType.UPPER_CASE, "Foo_Schema", "foo_db", "Foo_Schema"),
- Arguments.of("upper case identifier pattern formats default
schema", IdentifierPatternType.UPPER_CASE, null, "foo_db", "FOO_DB"),
- Arguments.of("lower case identifier pattern formats default
schema", IdentifierPatternType.LOWER_CASE, null, "FOO_DB", "foo_db"),
- Arguments.of("keep origin identifier pattern keeps default
schema", IdentifierPatternType.KEEP_ORIGIN, null, "Foo_Db", "Foo_Db"),
- Arguments.of("null database name keeps null default schema",
IdentifierPatternType.UPPER_CASE, null, null, null));
- }
-
private static Stream<Arguments> formatIdentifierPatternArguments() {
return Stream.of(
Arguments.of("identifier pattern upper case",
IdentifierPatternType.UPPER_CASE, "FOO"),
