terrymanu commented on PR #39742: URL: https://github.com/apache/shardingsphere/pull/39742#issuecomment-5553413187
### Result **Review Result: Mergeable** No blocking issues were found. The change correctly fixes `OFFSET ... FETCH` pagination parsing for PostgreSQL and openGauss. ### Evidence - Both the offset and fetched row count are now preserved. - Parameter marker order remains unchanged. - PostgreSQL parser tests passed: 1,172 tests. - openGauss parser tests passed: 930 tests. - PostgreSQL E2E tests passed: 330 tests. - openGauss E2E tests passed: 382 tests. - Spotless, Checkstyle, and XML validation passed. - No public API, SPI, dependency, or module boundary was changed. ### Coverage The tests cover `OFFSET ... FETCH` parsing and execution for PostgreSQL and openGauss. All changes are local and directly related to the reported pagination issue. ### Recommendation Approve and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
