Swastyy commented on issue #35894: URL: https://github.com/apache/shardingsphere/issues/35894#issuecomment-5584200350
This appears to already be fixed. pom.ftl now defaults the repository variable when it's not set in config.yaml: <#assign repository = repository!'JDBC'> That was added in commit 48bd50b5a9b (https://github.com/apache/shardingsphere/commit/48bd50b5a9bb441a358e0def35cd9c85b91dcaec) via #37524 ("Fix generated JDBC samples dependencies and templates"), merged 2025-12-25. With the default in place, the FreeMarker template no longer errors on a missing repository, and the shardingsphere-standalone-mode-repository-jdbc dependency (which transitively pulls in shardingsphere-standalone-mode-core, the module providing the StandaloneYamlPersistRepositoryConfigurationSwapper SPI implementation) gets added correctly — resolving the runtime SPI-00001 error as well. There's also a regression test covering this exact scenario: PomTemplateTest.assertStandaloneRepositoryDefaultsToJdbcDependency in examples/shardingsphere-jdbc-example-generator/src/test/java/PomTemplateTest.java. Since the fix landed via an unrelated PR that didn't reference this issue, it never got closed. Suggest closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
