terrymanu commented on PR #39186: URL: https://github.com/apache/shardingsphere/pull/39186#issuecomment-5586796478
The finding from the previous review is retained. There has been no implementation update since the review, and the proposed change still does not address the lifecycle reported in the issue. The connection-offset snapshot is stored in a `JDBCEnumerable` instance, but the correlated execution path creates a new instance for each outer row. Therefore, the snapshot is not reused across the actual repeated scans. The added test reuses a single instance and does not exercise that production path. This requires reconsidering which query-lifecycle component should own the reusable state and adding a regression test that starts from an actual correlated execution. I am closing this PR due to inactivity. Please continue the design discussion in [#37438](https://github.com/apache/shardingsphere/issues/37438) before opening a new PR based on the latest `master`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
