terrymanu commented on PR #39774: URL: https://github.com/apache/shardingsphere/pull/39774#issuecomment-5588987519
### Result **Review Result: Mergeable** The test unrelated to the Coordinator Registry Center SPI refactoring has been removed. The current diff is minimal, with no further required changes identified. ### Evidence - `PipelineAPIFactoryTest.java` → removed the unrelated Governance Facade initialization failure test and its unused import → keeps the PR scope minimal → the removed test did not cover behavior changed by this PR. - Removed six untracked `.pyc` files generated by Codex. The working tree now contains only the 15-line deletion from the test file. - Spotless: exit 0; the target file was already clean. - Checkstyle: exit 0; 0 violations. - Relevant tests: exit 0; 24 tests, 0 failures or errors. - Scoped package: exit 0; all three module JARs were built successfully. - Apache RAT: exit 0; 0 unapproved or unknown licenses. - The final search confirmed that Pipeline and Schedule common source code and direct dependencies no longer contain ZooKeeper-specific coupling. The SPI is annotated with `@SingletonSPI`. ### Coverage - Local candidate baseline: `46769ed1a66`; candidate: `8b8b88d6f9` plus the current single-file cleanup. - HEAD was updated externally during the task. No Git write operation was performed, and unrelated baseline changes were not modified. - Reviewed the SPI contract, ZooKeeper Provider, Pipeline, Statistics Worker, lifecycle management, dependencies, service registration, and tests. - No unresolved evidence gaps remain. This result covers code correctness only; remote CI was not reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
