terrymanu commented on PR #39205: URL: https://github.com/apache/shardingsphere/pull/39205#issuecomment-5586804567
The findings from the previous review are retained. There has been no implementation update since the review, and the routing contract remains ambiguous. The current approach allows the same name to represent both a logical Shadow data source and a physical production data source. When those namespaces overlap, the lookup may resolve to the wrong production database. It can also rebuild and reorder physical route units even when no Shadow mapping matches. This needs an unambiguous logical/physical route-provenance and name-resolution design before implementation continues. I am closing this PR due to inactivity. Please discuss the contract in [#37081](https://github.com/apache/shardingsphere/issues/37081) before opening a new PR based on the latest `master`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
