The GitHub Actions job "Nightly - E2E SQL" on shardingsphere.git/master has 
succeeded.
Run started by GitHub user menghaoranss (triggered by menghaoranss).

Head commit for run:
46769ed1a66de8a712a45fbe7230898ccf4f8ef1 / Eunbin Son 
<[email protected]>
Remove unused mask DistSQL keyword ADDRESS_RANDOM_REPLACE (#39363)

* Remove unused mask DistSQL keyword ADDRESS_RANDOM_REPLACE

* Instantiate mask DistSQL visitor directly in parser test

AGENTS.md forbids direct reflection APIs in tests. The visitor test
obtained the visitor through getDeclaredConstructor().newInstance(),
which also forced @SneakyThrows(ReflectiveOperationException.class).

Construct MaskDistSQLStatementVisitor directly and drop the now
unneeded @SneakyThrows. Parser assertions are unchanged.

* Move mask DistSQL keyword regression to parser IT

MaskDistSQLStatementVisitorTest verified the Keyword.g4 change through the
lexer, parser and visitor although this change does not touch
MaskDistSQLStatementVisitor, which would have made Mask the only module
keeping a local *StatementVisitorTest after #39465 and #39463 migrated the
equivalent coverage to parser IT.

Remove the module-local test and cover the removed keyword with one
CREATE MASK RULE case named address_random_replace in the shared parser
IT fixtures.

---------

Co-authored-by: Liang Zhang <[email protected]>

Report URL: https://github.com/apache/shardingsphere/actions/runs/34243363188

With regards,
GitHub Actions via GitBox

Reply via email to