terrymanu commented on PR #39161: URL: https://github.com/apache/shardingsphere/pull/39161#issuecomment-5586789322
The findings from the previous review are retained. There has been no implementation update since the review, and the design concerns remain unresolved. The current approach attempts to reconstruct JDBC setter provenance during replay, after SQL rewrite and batch processing may already have discarded that information. It also does not define a safe, repeatable lifecycle for stream and reader parameters across multiple physical statements. Addressing this requires a redesigned parameter-binding provenance model rather than incremental changes to the current implementation. I am closing this PR due to inactivity. If you would like to continue, please first discuss and agree on the ownership and lifecycle semantics in [#37504](https://github.com/apache/shardingsphere/issues/37504), then open a new PR based on the latest `master`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
