terrymanu commented on PR #39777: URL: https://github.com/apache/shardingsphere/pull/39777#issuecomment-5595552438
### Result **Review Result: Mergeable** The dependency removal matches Seata 2.6.0’s published runtime contract and introduces no identified correctness, compatibility, packaging, or performance regression. ### Evidence - PR head [`efd7d0bf`](https://github.com/apache/shardingsphere/commit/efd7d0bf86cb8a1b7a8168017407ac5dc53dd9ac) removes only Commons Lang 2 declarations from [`seata-at/pom.xml`](https://github.com/apache/shardingsphere/blob/efd7d0bf86cb8a1b7a8168017407ac5dc53dd9ac/kernel/transaction/type/base/seata-at/pom.xml#L29-L71). - Seata’s official [2.6.0 migration change](https://github.com/apache/incubator-seata/pull/7716) replaced Commons Lang 2 with Commons Lang 3. The published [Seata 2.6.0 POM](https://repo.maven.apache.org/maven2/org/apache/seata/seata-all/2.6.0/seata-all-2.6.0.pom) declares Commons Lang 3 and not Commons Lang 2. - The checksum-verified Seata 2.6.0 JAR contains no `org/apache/commons/lang` bytecode references; the preceding 2.5.0 artifact does. - Exact-head verification: - Focused Seata AT reactor tests: exit 0; 15 tests passed. - Reactor package: exit 0. - Module dependency tree: exit 0; zero `commons-lang:commons-lang` matches. - JDBC `transaction-seata` runtime dependency tree: exit 0; zero Commons Lang 2 matches. - `git diff --check`: exit 0. - A preliminary module-only test was excluded because it resolved an incompatible locally installed transaction SPI. Rebuilding the exact public-head dependency chain with `-am` eliminated that environment mismatch. - No credible performance regression exists: the PR removes a dependency edge without changing executable code, algorithms, I/O, synchronization, or allocation behavior. ### Coverage - Candidate: public PR [#39777](https://github.com/apache/shardingsphere/pull/39777), Code Correctness Review. - Baseline: `a326cb1db10124f6df09b8a20fa10a534bb8f3ed`; head: `efd7d0bf86cb8a1b7a8168017407ac5dc53dd9ac`; merge-base equals the baseline. - GitHub and local triple-dot scopes match: 1 of 1 changed files accounted for. - Behavior cluster: Seata AT Commons Lang 2 dependency removal and its published/distribution classpath impact. - Completed lenses: root cause and behavior; blast radius and contracts; tests, runtime, and operations. - Reviewed risks: dependency/version alignment, runtime compatibility, downstream packaging, licenses, testing, and functional/performance non-regression. - Existing unrelated working-tree changes were excluded; verification used an exact-head archive. - Unresolved evidence gaps: none. - This verdict is code-scope only; CI and GitHub Actions were not reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
