terrymanu commented on PR #39789:
URL: https://github.com/apache/shardingsphere/pull/39789#issuecomment-5614861056
### Result
**Review Result: Mergeable**
Both changes are minimal and do not extend to any other rules.
### Evidence
- `src/resources/checkstyle.xml`
- Added a precise XPath rule to detect all occurrences of `final
@Annotation`.
- Removed `SeverityMatchFilter` to restore output from existing
warning-level checks.
- All four known violations were detected, producing the expected `BUILD
FAILURE`.
- Correct ordering, `@Nullable final`: 0 violations and `BUILD SUCCESS`.
- Warnings are now reported correctly, while the module still produces
`BUILD SUCCESS`.
- XML parsing, `git diff --check`, and Apache RAT all passed.
- Spotless does not cover general XML files, so it is not applicable.
- Official Checkstyle 14.0.0 references:
- https://checkstyle.org/checks/coding/matchxpath.html
- https://checkstyle.org/filters/severitymatchfilter.html
### Coverage
- Candidate type: standalone local change.
- Baseline: `a8ebfa6434ae9e5b0607c91a0df5388ceb5f86e6`
- Reviewed file: `src/resources/checkstyle.xml`
- Diff: 4 additions and 2 deletions.
- Correctness, scope, readability, security, and performance were reviewed;
no unresolved issues remain.
- CI was not reviewed. A full Checkstyle run will fail because of the four
existing violations explicitly accepted by the user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
