terrymanu commented on PR #39816: URL: https://github.com/apache/shardingsphere/pull/39816#issuecomment-5646303783
### Result **Review Result: Mergeable** The local candidate addresses all three blocking issues. The four local file changes still need to be included in the public PR. ### Changes - `MigrationDataConsistencyCheckerTest.java:60`: Verifies that the inventory check phase reaches `EXECUTE_INVENTORY_TASK` while preserving the existing test structure. - `ShowMigrationCheckStatusExecutorTest.java:38`: Locks the 15 column names, column order, row value order, and row value count. - English and Chinese `show-migration-check-status` documentation: Adds the `status` column and the `FINISHED` example value. ### Evidence - `ConsistencyCheckJobItemContextTest`: 3/3 passed - `ConsistencyCheckJobAPITest`: 7/7 passed - `MigrationDataConsistencyCheckerTest`: 2/2 passed - `ShowMigrationCheckStatusExecutorTest`: 2/2 passed - Spotless: All 11 applicable Java files passed - Checkstyle: 0 violations across all 5 affected modules - Apache RAT: Passed - Forbidden-code scan: 0 matches - English and Chinese examples: 15 columns and 15 row values ### Coverage - Candidate: PR head `f127e71d7706dd8213cda7825a0506a3810103ec` plus four authorized local file changes. - All 13 effective candidate files were reviewed across status ownership and persistence, migration phase transitions, and SHOW output. - No unresolved code-correctness findings remain. - CI and the full repository build were not reviewed. - No commit, push, fetch, staging, or other Git write was performed. ### Code Review Suggestion Please add focused regression coverage for the new status contract. `MigrationDataConsistencyCheckerTest` should assert that the progress context reaches `EXECUTE_INVENTORY_TASK`. A dedicated `ShowMigrationCheckStatusExecutorTest` should lock the exact 15-column order and row value count, including `status`. Please also update the English and Chinese `SHOW MIGRATION CHECK STATUS` examples so that their output matches the executor. ### Suggested Commit Message `Add consistency check status coverage and documentation` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
