terrymanu commented on PR #39818: URL: https://github.com/apache/shardingsphere/pull/39818#issuecomment-5647079257
### Result **Review Result: Mergeable** The requirement has been implemented: in Maven source trees, only code under `src/main/**` may be the subject of a new or updated test. Code under `src/test/**` does not require test coverage, but the affected tests must still compile and run. ### Evidence - Added the directory boundary to `.codex/skills/code-implementation/references/rules/testing.md:20`. - Removed the exception that allowed independently distributed test-support artifacts under `src/test/**` to be tested. - Tightened the existing canary at `.codex/harness/agents/cases.toml:1121`; no 151st case was added. - The canary now receives the complete `testing-rules` content through the `test-write` profile. - `$gen-ut` already accepts production classes only, so no duplicate change was needed. - Harness unit tests: 99/99 passed. - Deterministic policy validation: passed. - Affected-profile read traces: 238/238 passed. - Network semantic validation: only one case ran and passed in 17.62 seconds. - The model correctly returned `refuse` with `production_behavior_test_required`. - The complete 150-case suite was not run; the total remains 150 cases. - TOML parsing and `git diff --check`: passed. - The official Skill validator could not start because PyYAML is unavailable. Since the Skill frontmatter was unchanged, equivalent frontmatter, reference-path, and harness validations were completed successfully. - No Git mutations were performed. ### Coverage - Candidate type: standalone local candidate. - Baseline: `e2d3643d174e6bf22559987c7181c91e089f8a8d`. - Both changed files were fully reviewed. - Root-cause, blast-radius, tests/runtime, and convergence review passes were completed with zero new findings. - Checkstyle, Spotless, and Maven: not applicable because no Java, Maven, or product code changed. - CI was not reviewed; this result covers the local candidate only. - Unresolved evidence gaps: none. - After merging or installation, the updated Skill discovery and user-visible behavior should be verified in a new task. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
