This is an automated email from the ASF dual-hosted git repository.
terrymanu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new a4ad45f6abd Remove useless DQLExclusiveExecutionDetectorTest (#39824)
a4ad45f6abd is described below
commit a4ad45f6abd3ddd9909ced71fb5835791a951a4b
Author: Liang Zhang <[email protected]>
AuthorDate: Sun Sep 13 10:03:16 2026 +0800
Remove useless DQLExclusiveExecutionDetectorTest (#39824)
---
.../sql/dql/DQLExclusiveExecutionDetectorTest.java | 75 ----------------------
1 file changed, 75 deletions(-)
diff --git
a/test/e2e/sql/src/test/java/org/apache/shardingsphere/test/e2e/sql/it/sql/dql/DQLExclusiveExecutionDetectorTest.java
b/test/e2e/sql/src/test/java/org/apache/shardingsphere/test/e2e/sql/it/sql/dql/DQLExclusiveExecutionDetectorTest.java
deleted file mode 100644
index 34a82556244..00000000000
---
a/test/e2e/sql/src/test/java/org/apache/shardingsphere/test/e2e/sql/it/sql/dql/DQLExclusiveExecutionDetectorTest.java
+++ /dev/null
@@ -1,75 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.shardingsphere.test.e2e.sql.it.sql.dql;
-
-import org.junit.jupiter.params.ParameterizedTest;
-import org.junit.jupiter.params.provider.Arguments;
-import org.junit.jupiter.params.provider.MethodSource;
-
-import java.util.stream.Stream;
-
-import static org.junit.jupiter.api.Assertions.assertFalse;
-import static org.junit.jupiter.api.Assertions.assertTrue;
-
-class DQLExclusiveExecutionDetectorTest {
-
- @ParameterizedTest(name = "{0}")
- @MethodSource("exclusiveExecutionSQLProvider")
- void assertRequiresExclusiveExecution(final String name, final String sql)
{
-
assertTrue(DQLExclusiveExecutionDetector.requiresExclusiveExecution(sql));
- }
-
- private static Stream<Arguments> exclusiveExecutionSQLProvider() {
- return Stream.of(
- Arguments.of("For update", "SELECT * FROM t_order WHERE
order_id = 1 FOR UPDATE"),
- Arguments.of("For no key update", "SELECT * FROM t_order FOR
NO KEY UPDATE"),
- Arguments.of("For share", "SELECT * FROM t_order FOR SHARE"),
- Arguments.of("For key share", "SELECT * FROM t_order FOR KEY
SHARE"),
- Arguments.of("Lock in share mode", "SELECT * FROM t_order LOCK
IN SHARE MODE"),
- Arguments.of("SQL Server updlock", "SELECT * FROM t_order WITH
(UPDLOCK) WHERE order_id = 1"),
- Arguments.of("SQL Server holdlock", "SELECT * FROM t_order
WITH (ROWLOCK, HOLDLOCK)"),
- Arguments.of("SQL Server xlock", "SELECT * FROM t_order WITH
(XLOCK, TABLOCKX)"),
- Arguments.of("DB2 keep update locks", "SELECT * FROM t_order
WITH RS USE AND KEEP UPDATE LOCKS"),
- Arguments.of("DB2 keep share locks", "SELECT * FROM t_order
WITH CS USE AND KEEP SHARE LOCKS"),
- Arguments.of("With lock", "SELECT * FROM t_order WITH LOCK"),
- Arguments.of("Insert returning", "INSERT INTO
t_with_generated_id (val) VALUES (?) RETURNING *, id, val aliased_val"),
- Arguments.of("Update returning", "UPDATE t_order SET status =
'OK' WHERE order_id = 1 RETURNING order_id"),
- Arguments.of("Delete returning", "DELETE FROM t_order WHERE
order_id = 1 RETURNING order_id"));
- }
-
- @ParameterizedTest(name = "{0}")
- @MethodSource("nonExclusiveExecutionSQLProvider")
- void assertDoesNotRequireExclusiveExecution(final String name, final
String sql) {
-
assertFalse(DQLExclusiveExecutionDetector.requiresExclusiveExecution(sql));
- }
-
- private static Stream<Arguments> nonExclusiveExecutionSQLProvider() {
- return Stream.of(
- Arguments.of("Plain select", "SELECT * FROM t_order"),
- Arguments.of("For update literal", "SELECT 'FOR UPDATE' AS
content FROM t_order"),
- Arguments.of("For update comment", "SELECT * FROM t_order --
FOR UPDATE"),
- Arguments.of("For update block comment", "SELECT * FROM
t_order /* FOR UPDATE */"),
- Arguments.of("For update quoted identifier", "SELECT \"FOR
UPDATE\" FROM t_order"),
- Arguments.of("Non select DML", "UPDATE t_order SET status =
'FOR UPDATE' WHERE order_id = 1"),
- Arguments.of("No lock hint", "SELECT * FROM t_order WITH
(NOLOCK)"),
- Arguments.of("For read only", "SELECT * FROM t_order FOR READ
ONLY"),
- Arguments.of("CTE named lock", "WITH lock AS (SELECT * FROM
t_order) SELECT * FROM lock"),
- Arguments.of("Returning literal", "SELECT 'INSERT INTO t_order
RETURNING order_id' AS content FROM t_order"),
- Arguments.of("Returning comment", "SELECT * FROM t_order --
INSERT INTO t_order RETURNING order_id"));
- }
-}
