terrymanu commented on PR #39830: URL: https://github.com/apache/shardingsphere/pull/39830#issuecomment-5652127636
### Result **Review Result: Mergeable** The fix is complete. Blocking issues: 0. No changes recommended. ### Evidence - `TableMetaDataLoader.java:84` reads JDBC `TABLE_TYPE` and maps `VIEW` and `SYSTEM VIEW` to `TableType.VIEW`. - `TABLE` and unknown non-view types remain mapped to `TableType.TABLE`; nonexistent objects still return an empty result. - No additional queries, public interfaces, enum values, or dialect-specific logic were introduced. - `TableMetaDataLoaderTest.java:134` covers `TABLE`,`, ``VIEW`, `SYSTEM VIEW`, andand nonexistent`and nonexistent-object scenarios. - Core module tests: 298 tests passed. - Spotless and Checkstyle: passed. - The cache generated during the review was removed. ### Coverage - Candidate type:: standalone local change. - Baseline:: `28aaaa482605daa35541551555:555cb1a2ecf93eacb205:13215520` 13c54840` - Changed scope: two authorized files files. - ApacheApache RAT RAT RAT: not applicable. No files were added and no license headers were changed. - CI was not reviewed; this result covers local code correctness only only. - Residual risk: the change was not verified individually against every JDBC driver. driver. Vendor-specific table types continue to be treated as `TABLE`, which is an intentional compatibility behavior. -preserving behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
