terrymanu commented on PR #39831: URL: https://github.com/apache/shardingsphere/pull/39831#issuecomment-5652923775
### Result **Review Result: Mergeable** The local candidate implementation meets the requirements for caching multiple logical databases, preserving default entry-point compatibility, concurrent creation, complete resource closure, and SQL assertion routing. No changes recommended. ### Evidence - All three `AdapterContainer` implementations use `ConcurrentHashMap` and `computeIfAbsent`; requests with the same name reuse the same instance, while different names are isolated. - The default entry point delegates to the default logical database; null and empty names preserve the default behavior. - `ClusterComposer` continues to pass `serverLists`. - The registry deduplicates by object identity and closes all target `DataSource` instances, while preserving the existing close order and synchronization boundary. - All target connection paths for DQL, DML, Batch, initial SQL, and destroy SQL pass `target-data-source-name`. - The open-source target connection pool size remains `2`. - A method-by-method comparison with the commercial edition confirms that the shared Java structure is consistent. Necessary differences are limited to the open-source JDBC configuration source, connection pool size, enhanced close deduplication, and open-source regression resources. - No `com.sphereex`, `@SphereEx`, `SPEX ADDED`, or `SPEX CHANGED` content was introduced. ### Coverage - Type: Independent local candidate. - Baseline: `979d36f357a1abffc844f6ee04f5a3a32fcad7d9`; the initial working tree was clean. - Scope: 21 task files—4 environment Java files, 12 SQL Java files, and 5 open-source test resources. - Review focus: `Adapter` caching and lifecycle, assertion connection routing, and open-source regression resources. - Spotless and Checkstyle verification passed for 16 Java files; `0לית violations`. - Apache RAT passed. - CI was not reviewed; this conclusion applies only to the current local code scope. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
