terrymanu commented on PR #39840: URL: https://github.com/apache/shardingsphere/pull/39840#issuecomment-5654732133
### Result **Review Result: Mergeable** The standalone local candidate fixes the three confirmed metadata defects without expanding into the deferred permission, collation, empty-table, expression-index, or model-design concerns. ### Evidence - `PostgreSQLMetaDataLoader.java:53,218` loads `is_identity` while retaining `nextval(...)` detection for serial columns. - `PostgreSQLMetaDataLoader.java:60-63` associates foreign keys through `pg_constraint.conrelid` and `confrelid`, eliminating reliance on non-unique constraint names. - `PostgreSQLMetaDataLoader.java:71-76` and `OpenGaussMetaDataLoader.java:69-74` expand `pg_index.indkey` by subscript and order results by index-column position. - PostgreSQL tests cover Identity without a `nextval(...)` default, existing serial behavior, ordinary defaults, the corrected foreign-key query, and composite index order. - openGauss tests cover composite index order while leaving its existing Identity handling unchanged. - Focused tests passed: PostgreSQL 3 tests and openGauss 11 tests. - Both complete connector-module test suites passed: 55 tests, 0 failures, 0 errors. - Exact-file Spotless and Checkstyle checks passed with 0 violations. - Both connector modules packaged successfully. ### Coverage - Candidate type: standalone local candidate. - Baseline: `f05ee36c6bf62b7fb13225f90f8e59fbd8bbee45`. - Reviewed delta: 4 modified Java files across the PostgreSQL and openGauss connector modules. - Behavior clusters reviewed: PostgreSQL column generation, PostgreSQL foreign keys, PostgreSQL index ordering, openGauss index ordering, and their regression tests. - Root-cause, blast-radius, tests/runtime, and final convergence passes completed with no findings. - PostgreSQL 11 and openGauss 3.1 compatibility was checked against their documented `generate_subscripts` behavior. - No public API, SPI, metadata model, dependency, or configuration changes. - No unresolved evidence gaps. - This is a code-scope review; CI was not reviewed. Current-candidate local style and build verification completed successfully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
