terrymanu commented on PR #39839: URL: https://github.com/apache/shardingsphere/pull/39839#issuecomment-5654589064
### Result **Review Result: Mergeable** - Blocking Issues: 0 - Required Changes: None - Review Recommendations: No changes recommended. ### Evidence - Oracle composite index columns are now ordered by `INDEX_NAME` and `COLUMN_POSITION`. - Index names, uniqueness, and column membership remain unchanged. - The existing test now covers a composite index and verifies column order. - The exact metadata SQL is verified by the JDBC mock. - Runtime handling of `NLS_COMP`, `NLS_SORT`, and `caseSensitive` remains unchanged. - The misleading TODO about resolving case sensitivity from metadata-session parameters was removed. - The final diff contains only the two approved Oracle metadata files. ### Coverage - Candidate Type: Local-only changes - `OracleMetaDataLoaderTest`: 29 tests passed, 0 failures, 0 errors - Spotless: 2 files checked, no formatting changes required - Checkstyle: 0 violations - `git diff --check`: Passed - Apache RAT: Not applicable; no files or license headers were added - Oracle E2E: Not run; the unit test verifies the generated SQL and preserves the ordered result ### Commit Message `Fix Oracle composite index column order` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
