thswlsqls opened a new pull request, #39855:
URL: https://github.com/apache/shardingsphere/pull/39855
Fixes #39852.
Changes proposed in this pull request:
- `ConditionValueBetweenOperatorGenerator.generate()` ignored
`BetweenExpression.isNot()`, so `sharding_column NOT BETWEEN a AND b` produced
the closed range `[a, b]` as a sharding condition, the opposite of the
predicate.
- With another condition such as `account_id = 11 AND account_id NOT
BETWEEN 1 AND 5`, the list and range values intersected to an empty set, the
route became always-false unicast and the matching row was silently dropped.
- Return `Optional.empty()` when `isNot()` is true, so a negated BETWEEN
is excluded from sharding conditions and the statement is routed by the
remaining conditions or broadcast.
- Aligns with the sibling `ConditionValueInOperatorGenerator`, which
already excludes `NOT IN` this way since #32076; `BetweenExpressionConverter`
in SQL federation also honors the flag.
- Add `assertGenerateConditionValueWithNotBetween`, which fails on master
(range present) and passes with this change.
- Verification scope: module-scoped `./mvnw install -pl
features/sharding/core -am -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`
(BUILD SUCCESS, 878 tests, 0 failures) plus spotless/checkstyle/apache-rat on
the module; the full-repository `clean install` and E2E were not run locally.
AI assistance: Claude Code was used to draft the change and its unit test in
`features/sharding/core`. I reviewed, verified, and take responsibility for
every line submitted.
---
Before committing this PR, I'm sure that I have checked the following
options:
- [x] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the
pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`. Ran the module-scoped equivalent
instead: `./mvnw install -pl features/sharding/core -am -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e` (BUILD SUCCESS) and
`spotless:apply`, `checkstyle:check`, `apache-rat:check` with `-Pcheck -pl
features/sharding/core`.
- [ ] I have made corresponding changes to the documentation. No
documentation describes this routing behavior; none needed.
- [x] I have added corresponding unit tests for my changes.
- [x] I have updated the Release Notes of the current development version.
For more details, see [Update Release
Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
- [x] I have disclosed the tool and affected files or scope for any material
AI assistance, as required by the [AI-assisted contribution policy].
[AI-assisted contribution policy]:
https://github.com/apache/shardingsphere/blob/master/AI_POLICY.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
