thswlsqls opened a new pull request, #39862:
URL: https://github.com/apache/shardingsphere/pull/39862
Fixes #39861.
Changes proposed in this pull request:
- `IntervalShardingAlgorithm.hasIntersection()` filled the missing
endpoint of a one-sided range with `datetime-lower`/`datetime-upper` before
calling `Range.range(...)`, so `create_time < '<before datetime-lower>'` or
`create_time >= '<after datetime-upper>'` produced lower > upper and Guava
threw `IllegalArgumentException: Invalid range`.
- The same substitution turned `create_time > '<datetime-upper>'` into an
empty range, so the last slot table was silently skipped although a precise
value in that slot routes there.
- Convert the query range to a temporal range as-is (`Range.range`,
`Range.downTo`, `Range.upTo`, `Range.all`) and intersect it with each slot, so
out-of-bounds one-sided ranges behave like the closed-range and precise-value
paths; the unused window parameters and `BoundType` import are removed.
- The sibling `AutoIntervalShardingAlgorithm` clamps out-of-bounds
one-sided ranges without throwing.
- Add `assertUpperHalfRangeDoShardingBeforeDateTimeLower`,
`assertLowerHalfRangeDoShardingAfterDateTimeUpper` and
`assertLowerHalfRangeDoShardingFromDateTimeUpper`; on master the first two
throw `IllegalArgumentException` and the third returns an empty set.
- Verification scope: module-scoped `./mvnw install -pl
features/sharding/core -am -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`
(BUILD SUCCESS, 880 tests, 0 failures) plus spotless/checkstyle/apache-rat on
the module; full-repository `clean install` and E2E not run locally.
AI assistance: Claude Code was used to draft the change and its unit tests
in `features/sharding/core`. I reviewed and verified every line submitted.
---
Before committing this PR, I'm sure that I have checked the following
options:
- [x] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the
pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`. Ran the module-scoped equivalent
instead: `./mvnw install -pl features/sharding/core -am -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e` (BUILD SUCCESS) and
`spotless:apply`, `checkstyle:check`, `apache-rat:check` with `-Pcheck -pl
features/sharding/core`.
- [ ] I have made corresponding changes to the documentation. The documented
INTERVAL configuration and semantics are unchanged; none needed.
- [x] I have added corresponding unit tests for my changes.
- [x] I have updated the Release Notes of the current development version.
For more details, see [Update Release
Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
- [x] I have disclosed the tool and affected files or scope for any material
AI assistance, as required by the [AI-assisted contribution policy].
[AI-assisted contribution policy]:
https://github.com/apache/shardingsphere/blob/master/AI_POLICY.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
