thswlsqls opened a new pull request, #39869:
URL: https://github.com/apache/shardingsphere/pull/39869
Fixes #26750.
Changes proposed in this pull request:
- `ShardingRuleConfigurationChecker.checkTables()` validated an auto
table's `shardingStrategy` through `checkShardingStrategy()`, which returns
silently for `null` or `NONE`, so a YAML `autoTables` entry without
`shardingStrategy` passed the checker and later failed in
`ShardingRule.createShardingAutoTable()` with a `NullPointerException`
(`AlgorithmInitializationException` construction also throws NPE for `NONE`).
- Add `checkAutoTableShardingStrategy()` that rejects a missing or `NONE`
strategy with `MissingRequiredShardingConfigurationException("Auto table
sharding strategy", databaseName)` before delegating to the existing
`checkShardingStrategy()`.
- Auto tables have no default-strategy fallback:
`docs/.../yaml-config/rules/sharding.en.md` lists `shardingStrategy` as
required for `autoTables`, `ShardingTable` reads the auto table strategy
directly, and the default table strategy only accepts non-auto algorithms; the
DistSQL path already requires an algorithm for auto tables.
- Sharding `tables` and default strategies keep accepting `null`/`NONE` as
before.
- Add
`ShardingRuleConfigurationCheckerTest#assertCheckAutoTableWithoutShardingStrategyFailed`
and `#assertCheckAutoTableWithNoneShardingStrategyFailed`; on master both fail
because nothing is thrown.
- Verification scope: module-scoped `./mvnw install -pl
features/sharding/core -am -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`
(BUILD SUCCESS, 879 tests in the module, 0 failures) plus
spotless/checkstyle/apache-rat on the module; the full-repository `clean
install` and E2E were not run locally.
AI assistance: Claude Code was used to draft the change and its unit tests
in `features/sharding/core`. I reviewed, verified, and take responsibility for
every line submitted.
---
Before committing this PR, I'm sure that I have checked the following
options:
- [x] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the
pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`. Ran the module-scoped equivalent
instead: `./mvnw install -pl features/sharding/core -am -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e` (BUILD SUCCESS) and
`spotless:apply`, `checkstyle:check`, `apache-rat:check` with `-Pcheck -pl
features/sharding/core`.
- [ ] I have made corresponding changes to the documentation. The
documentation already lists `shardingStrategy` as required for `autoTables`;
none needed.
- [x] I have added corresponding unit tests for my changes.
- [x] I have updated the Release Notes of the current development version.
For more details, see [Update Release
Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
- [x] I have disclosed the tool and affected files or scope for any material
AI assistance, as required by the [AI-assisted contribution policy].
[AI-assisted contribution policy]:
https://github.com/apache/shardingsphere/blob/master/AI_POLICY.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
