thswlsqls opened a new pull request, #39864:
URL: https://github.com/apache/shardingsphere/pull/39864
Fixes #39863.
Changes proposed in this pull request:
- `ShardingRouteContextCheckUtils.createShardingConditions()` used
`ShardingRule.findShardingColumn()` only as a presence check and built the
`ListShardingConditionValue` from the raw SQL identifier, so `UPDATE t_account
SET ACCOUNT_ID = 1 ...` with configured sharding column `account_id` failed in
`InlineShardingAlgorithm` with
`MismatchedInlineShardingAlgorithmExpressionAndColumnException` because
`algorithmExpression.contains(columnName)` is case-sensitive.
- Use the configured column name returned by `findShardingColumn()` for
the condition value, with a guard clause for non-sharding columns.
- Aligns with `WhereClauseShardingConditionEngine` and
`InsertClauseShardingConditionEngine`, which already build their condition
values from `shardingColumn.get()`; the same utility also serves `INSERT ... ON
DUPLICATE KEY UPDATE` through `ShardingInsertRouteContextChecker`.
- Add
`ShardingUpdateRouteContextCheckerTest#assertCheckWhenUpdateShardingColumnWithDifferentCaseFromConfiguration`;
on master it fails with
`MismatchedInlineShardingAlgorithmExpressionAndColumnException`.
- Verification scope: module-scoped `./mvnw install -pl
features/sharding/core -am -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`
(BUILD SUCCESS, 878 tests in the module, 0 failures) plus
spotless/checkstyle/apache-rat on the module; the full-repository `clean
install` and E2E were not run locally.
AI assistance: Claude Code was used to draft the change and its unit tests
in `features/sharding/core`. I reviewed, verified, and take responsibility for
every line submitted.
---
Before committing this PR, I'm sure that I have checked the following
options:
- [x] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the
pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`. Ran the module-scoped equivalent
instead: `./mvnw install -pl features/sharding/core -am -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e` (BUILD SUCCESS) and
`spotless:apply`, `checkstyle:check`, `apache-rat:check` with `-Pcheck -pl
features/sharding/core`.
- [ ] I have made corresponding changes to the documentation. The documented
sharding configuration and semantics are unchanged; none needed.
- [x] I have added corresponding unit tests for my changes.
- [x] I have updated the Release Notes of the current development version.
For more details, see [Update Release
Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
- [x] I have disclosed the tool and affected files or scope for any material
AI assistance, as required by the [AI-assisted contribution policy].
[AI-assisted contribution policy]:
https://github.com/apache/shardingsphere/blob/master/AI_POLICY.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
