terrymanu commented on PR #39883:
URL: https://github.com/apache/shardingsphere/pull/39883#issuecomment-5723634559
### Result
**Review Result: Mergeable**
The change is minimal and places validation at the shared entry point before
database rule configurations enter the checker and rule-building flow. No
correctness, compatibility, or performance blockers were found.
### Evidence
- Bean Validation runs before the early return when no dedicated checker
exists.
- The new test verifies that an invalid configuration without a checker
still throws `InvalidRuleConfigurationException`.
- Focused tests: 5 tests passed.
- Complete `infra/common` unit test suite: 1,132 tests passed.
- Spotless and Checkstyle: passed with 0 violations.
- Apache RAT: not applicable because no files were added and no license
configuration was changed.
### Coverage
- Candidate type: standalone local candidate.
- Baseline: `86c1519e4d6deaf68e18ee47196e81da2e114f62`.
- Reviewed files:
-
`infra/common/src/main/java/org/apache/shardingsphere/infra/config/rule/checker/DatabaseRuleConfigurationCheckEngine.java`
-
`infra/common/src/test/java/org/apache/shardingsphere/infra/config/rule/checker/DatabaseRuleConfigurationCheckEngineTest.java`
- The validation boundary, invocation paths, compatibility, test validity,
and performance impact were reviewed.
- Root-cause, blast-radius, tests/runtime, and convergence reviews were
completed with no unresolved evidence gaps.
- This result covers code correctness only; remote CI was not reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
