This is an automated email from the ASF dual-hosted git repository.
terrymanu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new fe72d47296d Refactor SQLRewriteEngineTestParametersBuilder (#39889)
fe72d47296d is described below
commit fe72d47296da4b0958cb8b5426cd78136595f3fa
Author: Liang Zhang <[email protected]>
AuthorDate: Fri Sep 18 20:47:29 2026 +0800
Refactor SQLRewriteEngineTestParametersBuilder (#39889)
---
.../engine/parameter/SQLRewriteEngineTestParametersBuilder.java | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git
a/test/it/rewriter/src/test/java/org/apache/shardingsphere/test/it/rewriter/engine/parameter/SQLRewriteEngineTestParametersBuilder.java
b/test/it/rewriter/src/test/java/org/apache/shardingsphere/test/it/rewriter/engine/parameter/SQLRewriteEngineTestParametersBuilder.java
index a866790d989..2d8bb8729a4 100644
---
a/test/it/rewriter/src/test/java/org/apache/shardingsphere/test/it/rewriter/engine/parameter/SQLRewriteEngineTestParametersBuilder.java
+++
b/test/it/rewriter/src/test/java/org/apache/shardingsphere/test/it/rewriter/engine/parameter/SQLRewriteEngineTestParametersBuilder.java
@@ -139,15 +139,18 @@ public final class SQLRewriteEngineTestParametersBuilder {
appendLiteralCases(type, fileName, actualRuleFile, each,
databaseType, result);
continue;
}
- SQLExecuteType sqlExecuteType = null ==
each.getInput().getParameters() || each.getInput().getParameters().isEmpty() ?
SQLExecuteType.LITERAL : SQLExecuteType.PLACEHOLDER;
result.add(new SQLRewriteEngineTestParameters(type,
each.getId(), fileName, actualRuleFile, each.getInput().getSql(),
createParameters(each.getInput().getParameters(),
each.getInput().getSql()), createOutputSQLs(each.getOutputs()),
createOutputGroupedParameters(each.getOutputs()),
- databaseType, sqlExecuteType));
+ databaseType, getSQLExecuteType(each)));
}
}
return result;
}
+ private static SQLExecuteType getSQLExecuteType(final
RewriteAssertionEntity each) {
+ return null == each.getInput().getParameters() ||
each.getInput().getParameters().isEmpty() ? SQLExecuteType.LITERAL :
SQLExecuteType.PLACEHOLDER;
+ }
+
private static String resolveRuleFile(final String ruleFile, final String
databaseType) {
return ruleFile.replace(DATABASE_TYPE_PLACEHOLDER,
databaseType).replace(DATABASE_TYPE_LOWER_PLACEHOLDER,
databaseType.toLowerCase(Locale.ENGLISH));
}