terrymanu commented on PR #39896: URL: https://github.com/apache/shardingsphere/pull/39896#issuecomment-5740475165
### Result **Review Result: Mergeable** The default MCP distribution now uses a dedicated license file. Category X JDBC drivers are no longer included in the distribution package, and existing database support is maintained through the `plugins/` directory. ### Evidence - MCP and its dependent modules have been successfully packaged. - All 32 third-party dependencies of the default distribution package are recorded in the MCP LICENSE file. - The default, `all`, `db-mysql`, and `db-mariadb` distributions no longer include MySQL/MariaDB JDBC drivers. - `PackagedDistributionE2ETest`: all 8 scenarios passed. - Java Checkstyle and Java/POM Spotless checks all passed. - Apache RAT: 0 unrecognized files. - The LICENSE and NOTICE files in the distribution package are consistent with the source code, and all 9 third-party license files have been packaged. ### Coverage - Type: Standalone local candidate change. - Baseline: `ea916d9597ed2bca0d3936415cf8c3a8504db325`. - Reviewed 18 task files, covering distribution configuration, licenses, user documentation, and packaging E2E. - Root cause analysis, impact scope, test run path, and final convergence check completed; no unresolved issues. - This is a code-scope review; remote CI was not checked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
