terrymanu commented on PR #39899: URL: https://github.com/apache/shardingsphere/pull/39899#issuecomment-5743130169
### Result **Review Result: Mergeable** The validation ownership, persistence boundary, and rule-item lifecycle are covered. No blocking correctness issues were found. ### Evidence - The conflict check was moved from the DistSQL executors to a Bean Validation constraint on `EncryptTableRuleConfiguration`. - The constraint covers YAML loading, rule construction, persistence, and individual configuration-center item changes. - Assisted-query and like-query column names are compared case-insensitively against every logic column in the same Encrypt table. - Superseded executor checks and their dedicated tests were removed, with no remaining references found. - All 31 Encrypt API tests and 21 Encrypt DistSQL handler tests passed. - Exact-file Spotless and Checkstyle checks passed for all eight changed Java files. Apache RAT also passed. ### Coverage - Candidate type: standalone local candidate. - Baseline: `3294acd45ed9c24474c479f4ef2b8e66a17ba786`. - Attributed delta: five production Java files and three test files. - Reviewed clusters: Encrypt configuration validation; removal of duplicate DistSQL validation and its error-timing impact. - Completed review lenses: root cause and behavior, blast radius and contracts, tests and runtime, and final convergence. - Unresolved evidence gaps: none. - This is a code-scope result only; remote CI was not reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
