terrymanu commented on PR #39910: URL: https://github.com/apache/shardingsphere/pull/39910#issuecomment-5754430549
### Result **Review Result: Mergeable** The implementation adds all remaining functions tracked by #31912 to the MySQL SQL Federation unsupported-function list. No issues blocking the merge were found. ### Evidence - The provider contains exactly 48 unsupported function names: the 44 remaining entries from #31912 and the 4 previously configured entries. - The production and test lists were compared mechanically and contain identical names without omissions or duplicates. - The existing unified, case-insensitive unsupported-function checking path is reused without changing its SPI or exception contract. - All 8 tests in `SQLNodeConverterEngineTest` and all 2 tests in `MySQLSQLFederationFunctionRegisterTest` passed. - Both changed files passed Spotless and Checkstyle. - No files or license headers were added, so Apache RAT is not applicable. ### Coverage - Candidate type: Standalone local candidate. - Baseline: `37a422075b29e14f67ab4f46f647943f963f9392`. - Review scope: 1 production file and 1 corresponding test file. - Behavior scope: MySQL SQL Federation unsupported-function classification. - Root cause, converted operator-name handling, compatibility impact, test validity, runtime path, and bounded lookup cost were reviewed. - Existing function implementations and registrations were intentionally left unchanged; the compiler rejects configured functions before Calcite validation and execution. - No unresolved evidence gaps were found. - This result covers code correctness only; GitHub CI was not reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
