terrymanu commented on PR #39915: URL: https://github.com/apache/shardingsphere/pull/39915#issuecomment-5756367105
### Result **Review Result: Mergeable** The production-code fix removes `BIN` from MySQL SQL Federation’s unsupported-function list and updates the corresponding unit-test expectation. The `BIN` implementation, registration, and existing E2E cases remain unchanged. ### Evidence - Focused unit tests passed: 19 tests, 0 failures. - Spotless, Checkstyle, and `git diff --check` passed. - Local E2E verification was blocked by an unrelated Proxy environment error: `Invalid license status: License not registered`. ### Coverage - Standalone local candidate based on `1bcf1101ad8`; only `MySQLSQLFederationFunctionRegister.java` and its test were changed, with one line removed from each. - Function registration, the unsupported-function check, existing BIN tests, and the complete diff were reviewed. No code-correctness issues remain. - This is a code-correctness assessment only. A new GitHub CI run was not reviewed, and E2E should be rerun in a working Proxy environment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
